From: Jonathan Dieter <jdieter@gmail.com>
Date: Fri, 14 Sep 2018 12:11:46 +0000 (+0100)
Subject: Set umask before running mkstemp because some UNIX flavors don't do this
X-Git-Tag: archive/raspbian/1.1.9+ds1-1+rpi1~1^2~126
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=af3d18b4fc492a83fdc47a4f980d9ab7c1990c0c;p=zchunk.git

Set umask before running mkstemp because some UNIX flavors don't do this
automatically.
(Coverity ID: 310912)

Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
---

diff --git a/src/lib/zck.c b/src/lib/zck.c
index a3359ea..eb58f8a 100644
--- a/src/lib/zck.c
+++ b/src/lib/zck.c
@@ -29,6 +29,7 @@
 #include <stdint.h>
 #include <stdbool.h>
 #include <string.h>
+#include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>
 #include <errno.h>
@@ -130,7 +131,10 @@ int get_tmp_fd(zckCtx *zck) {
     strncpy(fname+strlen(tmpdir), "/", 2);
     strncpy(fname+strlen(tmpdir)+1, template, strlen(template));
 
+    mode_t old_mode_mask;
+    old_mode_mask = umask (S_IXUSR | S_IRWXG | S_IRWXO);
     temp_fd = mkstemp(fname);
+    umask(old_mode_mask);
     if(temp_fd < 0) {
         free(fname);
         set_error(zck, "Unable to create temporary file");