From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Wed, 25 Sep 2013 08:45:53 +0000 (+0200)
Subject: x86/hap: Remove bogus assertion in hap_free_p2m_page()
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6292
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=ae7c6b64c063a755097806e30dc24b94fabbda09;p=xen.git

x86/hap: Remove bogus assertion in hap_free_p2m_page()

Coverity ID: 1055622

Coverity correctly points out that this ASSERT() is unconditionally true as an
unsigned integer is always >= 0.

Judging from the shadow counterpart and p2m callsites, there is nothing
invalid about freeing the final p2m page.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
---

diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index bff05d97a3..d3f64bdb97 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -289,7 +289,6 @@ static void hap_free_p2m_page(struct domain *d, struct page_info *pg)
     d->arch.paging.hap.p2m_pages--;
     d->arch.paging.hap.total_pages++;
     hap_free(d, page_to_mfn(pg));
-    ASSERT(d->arch.paging.hap.p2m_pages >= 0);
 
     paging_unlock(d);
 }