From: Eric Huss <eric@huss.org>
Date: Sat, 21 Apr 2018 18:18:05 +0000 (-0700)
Subject: Remove last TODO comments.
X-Git-Tag: archive/raspbian/0.35.0-2+rpi1~3^2^2^2^2^2^2^2~22^2~1^2~41^2~9
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=accc9b28677049c8dc7596782752102ff4d5cd98;p=cargo.git

Remove last TODO comments.
---

diff --git a/src/cargo/core/compiler/context/unit_dependencies.rs b/src/cargo/core/compiler/context/unit_dependencies.rs
index b329de85a..75dbd24f1 100644
--- a/src/cargo/core/compiler/context/unit_dependencies.rs
+++ b/src/cargo/core/compiler/context/unit_dependencies.rs
@@ -172,8 +172,6 @@ fn compute_deps_custom_build<'a, 'cfg>(
         kind: unit.kind,
         mode: CompileMode::Build,
     };
-    // TODO: ProfileFor may need to be TestDependency if the random target we
-    // picked is a test and `panic` is set.  Need it investigate.
     let deps = deps_of(&tmp, cx, deps, ProfileFor::Any)?;
     Ok(deps.iter()
         .filter_map(|unit| {
diff --git a/src/cargo/core/compiler/job_queue.rs b/src/cargo/core/compiler/job_queue.rs
index b6202a905..a713a6285 100644
--- a/src/cargo/core/compiler/job_queue.rs
+++ b/src/cargo/core/compiler/job_queue.rs
@@ -256,7 +256,13 @@ impl<'a> JobQueue<'a> {
         }
 
         let build_type = if self.is_release { "release" } else { "dev" };
-        // TODO FIXME: We don't know which pkg to display this for!
+        // NOTE: This may be a bit inaccurate, since this may not display the
+        // profile for what was actually built.  Profile overrides can change
+        // these settings, and in some cases different targets are built with
+        // different profiles.  To be accurate, it would need to collect a
+        // list of Units built, and maybe display a list of the different
+        // profiles used.  However, to keep it simple and compatible with old
+        // behavior, we just display what the base profile is.
         let profile = cx.profiles.base_profile(self.is_release);
         let mut opt_type = String::from(if profile.opt_level.as_str() == "0" {
             "unoptimized"