From: Andrew Cooper Date: Mon, 9 Sep 2013 17:43:40 +0000 (+0100) Subject: x86/mm: Fix possible increment of uninitialised variable X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6383 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=ac2f555e37f589fde27c68a306aaac14a424040b;p=xen.git x86/mm: Fix possible increment of uninitialised variable Discovered by Coverity, CID 1056101 When taking the continue branch on the first iteration of the loop, gfn would indeed be uninitialised when incremented. However, as gfn is unconditionally constructed from i{1..4} before use in the loop body, having it incremented in the loop header is useless. Therefore, simply remove it. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Acked-by: Tim Deegan --- diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index 302b621199..a1d565068d 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -691,7 +691,7 @@ static void p2m_change_type_global(struct p2m_domain *p2m, l1mfn = _mfn(l2e_get_pfn(l2e[i2])); l1e = map_domain_page(mfn_x(l1mfn)); - for ( i1 = 0; i1 < L1_PAGETABLE_ENTRIES; i1++, gfn++ ) + for ( i1 = 0; i1 < L1_PAGETABLE_ENTRIES; i1++ ) { flags = l1e_get_flags(l1e[i1]); if ( p2m_flags_to_type(flags) != ot )