From: Jonathan Dieter <jdieter@gmail.com>
Date: Fri, 14 Sep 2018 14:26:54 +0000 (+0100)
Subject: Make sure TMPDIR has a size limit
X-Git-Tag: archive/raspbian/1.1.9+ds1-1+rpi1~1^2~115
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=a78647d89acce6e6b0f61fde8efdfa15782bc92a;p=zchunk.git

Make sure TMPDIR has a size limit
(Coverity ID: 310902)

Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
---

diff --git a/src/lib/zck.c b/src/lib/zck.c
index fd04067..3b2fa07 100644
--- a/src/lib/zck.c
+++ b/src/lib/zck.c
@@ -129,7 +129,11 @@ int get_tmp_fd(zckCtx *zck) {
 
     if(tmpdir == NULL) {
         tmpdir = "/tmp/";
+    } else if(strlen(tmpdir) > 1024) {
+        set_error(zck, "TMPDIR environmental variable is > 1024 bytes");
+        return -1;
     }
+
     fname = zmalloc(strlen(template) + strlen(tmpdir) + 2);
     strncpy(fname, tmpdir, strlen(tmpdir));
     strncpy(fname+strlen(tmpdir), "/", 2);