From: Roger Pau Monne Date: Fri, 6 Sep 2013 10:36:26 +0000 (+0200) Subject: libxl: fix libxl__device_disk_from_xs_be to parse backend domid X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6370^2~8 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=a508caf0ebc4f834bd44c1d607e5b7bfabe43e3d;p=xen.git libxl: fix libxl__device_disk_from_xs_be to parse backend domid libxl__device_disk_from_xs_be was ignoring the backend domid, setting it to 0 by default. Fix this by parsing the backend disk path in order to fetch the backend domid. This fixes the issue reported when trying to block-detach disks that have it's backend on a driver domain. Signed-off-by: Roger Pau Monné Reported-by: G.R. Cc: Ian Jackson Acked-by: Ian Campbell --- diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 1bce4bb46f..7a7aaf90fe 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -2234,9 +2234,16 @@ static int libxl__device_disk_from_xs_be(libxl__gc *gc, libxl_ctx *ctx = libxl__gc_owner(gc); unsigned int len; char *tmp; + int rc; libxl_device_disk_init(disk); + rc = sscanf(be_path, "/local/domain/%d/", &disk->backend_domid); + if (rc != 1) { + LOG(ERROR, "Unable to fetch device backend domid from %s", be_path); + goto cleanup; + } + /* "params" may not be present; but everything else must be. */ tmp = xs_read(ctx->xsh, XBT_NULL, libxl__sprintf(gc, "%s/params", be_path), &len);