From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Thu, 20 Apr 2023 11:41:41 +0000 (+0800)
Subject: Do not use magic string for propfind prop element tag name
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~10^2~49^2~15
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=a386d8f0082a2b7f225dfa4aa6b5b31fe7d4890d;p=nextcloud-desktop.git

Do not use magic string for propfind prop element tag name

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/src/libsync/networkjobs.cpp b/src/libsync/networkjobs.cpp
index ca390ca01..e6b46fc1b 100644
--- a/src/libsync/networkjobs.cpp
+++ b/src/libsync/networkjobs.cpp
@@ -61,6 +61,7 @@ Q_LOGGING_CATEGORY(lcDetermineAuthTypeJob, "nextcloud.sync.networkjob.determinea
 Q_LOGGING_CATEGORY(lcSimpleFileJob, "nextcloud.sync.networkjob.simplefilejob", QtInfoMsg)
 
 constexpr auto notModifiedStatusCode = 304;
+constexpr auto propfindPropElementTagName = "prop";
 
 RequestEtagJob::RequestEtagJob(AccountPtr account, const QString &path, QObject *parent)
     : AbstractNetworkJob(account, path, parent)
@@ -623,13 +624,13 @@ bool PropfindJob::finished()
         }
 
         const auto rootElement = domDocument.documentElement();
-        const auto propNodes = rootElement.elementsByTagName("prop");
+        const auto propNodes = rootElement.elementsByTagName(propfindPropElementTagName);
 
         for (auto i = 0; i < propNodes.count(); ++i) {
             const auto propNode = propNodes.at(i);
             const auto propElement = propNode.toElement();
 
-            if (propElement.isNull() || propElement.tagName() != "prop") {
+            if (propElement.isNull() || propElement.tagName() != propfindPropElementTagName) {
                 continue;
             }