From: Jan Beulich Date: Tue, 22 Mar 2022 12:10:59 +0000 (+0100) Subject: x86/build: work around older GNU ld not leaving .got.plt empty X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~814 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=a2b8da2574586270207c6eb8e7aa8cd19eb74947;p=xen.git x86/build: work around older GNU ld not leaving .got.plt empty The initial three entries in .got.plt are "static", i.e. present independent of actual entries allocation of which is triggered by respective relocations. When no real entries are needed, halfway recent ld discards the "static" portion of the table as well, but older GNU ld fails to do so. Fixes: dedb0aa42c6d ("x86/build: use --orphan-handling linker option if available") Reported-by: Julien Grall Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Tested-by: Julien Grall --- diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index d33e295320..db2aaf7781 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -497,7 +497,13 @@ ASSERT(IS_ALIGNED(__bss_end, 8), "__bss_end misaligned") #ifndef EFI ASSERT(!SIZEOF(.got), ".got non-empty") -ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") +/* + * At least GNU ld 2.30 and earlier fail to discard the generic part of + * .got.plt when no actual entries were allocated. Permit this case alongside + * the section being empty. + */ +ASSERT(!SIZEOF(.got.plt) || SIZEOF(.got.plt) == 3 * 8, + "unexpected .got.plt size") ASSERT(!SIZEOF(.igot.plt), ".igot.plt non-empty") ASSERT(!SIZEOF(.iplt), ".iplt non-empty") ASSERT(!SIZEOF(.plt), ".plt non-empty")