From: Juergen Gross <jgross@suse.com>
Date: Wed, 20 Apr 2022 07:31:17 +0000 (+0200)
Subject: tools/libs/ctrl: don't set errno to a negative value
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~705
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=a0fb7e0e73483ed042d5ca34861a891a51ad337b;p=xen.git

tools/libs/ctrl: don't set errno to a negative value

The claimed reason for setting errno to -1 is wrong. On x86
xc_domain_pod_target() will set errno to a sane value in the error
case.

Fixes: ff1745d5882b ("tools: libxl: do not set the PoD target on ARM")
Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index ef62f66009..71608c00e9 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1293,9 +1293,7 @@ int xc_domain_get_pod_target(xc_interface *xch,
                              uint64_t *pod_cache_pages,
                              uint64_t *pod_entries)
 {
-    /* On x86 (above) xc_domain_pod_target will incorrectly return -1
-     * with errno==-1 on error. Do the same for least surprise. */
-    errno = -1;
+    errno = EOPNOTSUPP;
     return -1;
 }
 #endif