From: Steve Langasek <vorlon@debian.org>
Date: Sun, 14 Feb 2021 17:26:41 +0000 (+0000)
Subject: don't second-guess BDB ABI
X-Git-Tag: archive/raspbian/2.5.13+dfsg-3+rpi1~1^2^2^2^2^2^2^2~5
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=9f9facf8faf100ea746bacab39ca7da8cdc64307;p=openldap.git

don't second-guess BDB ABI

Bug-Debian: http://bugs.debian.org/651333
Forwarded: not-needed

OpenLDAP upstream conservatively assumes that any change to the version
number of libdb can result in an API-breaking change that could impact
the database.  In Debian, we know that such changes require bumping the
library soname and changing the package name, and demand such rigor from
our package maintainers even when upstreams don't deliver; so any such
check in the source code works against the packaging system by forcing
database upgrades when we know none are required.  Disable this check
so we rely on the packaging system to do its job.

Gbp-Pq: Name no-bdb-ABI-second-guessing
---

diff --git a/servers/slapd/back-bdb/init.c b/servers/slapd/back-bdb/init.c
index 86a1a971..a7567bc0 100644
--- a/servers/slapd/back-bdb/init.c
+++ b/servers/slapd/back-bdb/init.c
@@ -768,7 +768,7 @@ bdb_back_initialize(
 	bi->bi_controls = controls;
 
 	{	/* version check */
-		int major, minor, patch, ver;
+		int major, minor, patch;
 		char *version = db_version( &major, &minor, &patch );
 #ifdef HAVE_EBCDIC
 		char v2[1024];
@@ -782,17 +782,6 @@ bdb_back_initialize(
 		version = v2;
 #endif
 
-		ver = (major << 24) | (minor << 16) | patch;
-		if( ver != DB_VERSION_FULL ) {
-			/* fail if a versions don't match */
-			Debug( LDAP_DEBUG_ANY,
-				LDAP_XSTRING(bdb_back_initialize) ": "
-				"BDB library version mismatch:"
-				" expected " DB_VERSION_STRING ","
-				" got %s\n", version, 0, 0 );
-			return -1;
-		}
-
 		Debug( LDAP_DEBUG_TRACE, LDAP_XSTRING(bdb_back_initialize)
 			": %s\n", version, 0, 0 );
 	}