From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 28 Aug 2018 13:56:38 +0000 (+0100)
Subject: rombios: remove packed attribute for pushad_regs_t
X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~63^2~3385
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=9df4c648d79f32946b65d5795c172a91d7d71cfe;p=xen.git

rombios: remove packed attribute for pushad_regs_t

The structure already has explicitly padding.

Removing the attribute silences a clang 6 warning:

tcgbios.c:1519:34: error: taking address of packed member 'u' of class or structure 'pushad_regs_t' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
                                                  ®s->u.r32.edx);
                                                   ^~~~~~~~~~~~~~~

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/tools/firmware/rombios/32bit/rombios_compat.h b/tools/firmware/rombios/32bit/rombios_compat.h
index c0ae4151b5..3fe7d67721 100644
--- a/tools/firmware/rombios/32bit/rombios_compat.h
+++ b/tools/firmware/rombios/32bit/rombios_compat.h
@@ -52,7 +52,7 @@ typedef struct {
     Bit16u filler4;
     } r8;
   } u;
-} __attribute__((packed)) pushad_regs_t;
+} pushad_regs_t;