From: Julien Grall <jgrall@amazon.com>
Date: Wed, 23 Feb 2022 19:08:33 +0000 (+0000)
Subject: xen/mm: pg_offlined can be defined as bool in free_heap_pages()
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~906
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=9ba4c529985a1773852069889a5b53f2ed26c408;p=xen.git

xen/mm: pg_offlined can be defined as bool in free_heap_pages()

The local variable pg_offlined in free_heap_pages() can only take two
values. So switch it to a bool.

Fixes: 289610483fc43 ("mm: fix broken tainted value in mark_page_free")
Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index e971bf91e0..319029140f 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1437,8 +1437,9 @@ static void free_heap_pages(
 {
     unsigned long mask;
     mfn_t mfn = page_to_mfn(pg);
-    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
+    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn));
     unsigned int zone = page_to_zone(pg);
+    bool pg_offlined = false;
 
     ASSERT(order <= MAX_ORDER);
 
@@ -1447,7 +1448,7 @@ static void free_heap_pages(
     for ( i = 0; i < (1 << order); i++ )
     {
         if ( mark_page_free(&pg[i], mfn_add(mfn, i)) )
-            pg_offlined = 1;
+            pg_offlined = true;
 
         if ( need_scrub )
         {