From: Mike Hommey <mh+mozilla@glandium.org>
Date: Tue, 9 Aug 2022 20:42:44 +0000 (+0000)
Subject: Bug 1782988 - Fix use of arc4random_buf use in ping.cpp. r=gsvelto
X-Git-Tag: archive/raspbian/102.6.0esr-1_deb11u1+rpi1~1^2~24
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=993eb76e919199dc86c01eb296b8855f5eea10d5;p=firefox-esr.git

Bug 1782988 - Fix use of arc4random_buf use in ping.cpp. r=gsvelto

The code was probably never built before glibc 2.36, because before
that, only Android and some BSDs had arc4random_buf, but none of those
actually built this code.

Differential Revision: https://phabricator.services.mozilla.com/D154024

Gbp-Pq: Topic fixes
Gbp-Pq: Name Bug-1782988-Fix-use-of-arc4random_buf-use-in-ping.cp.patch
---

diff --git a/toolkit/crashreporter/client/ping.cpp b/toolkit/crashreporter/client/ping.cpp
index 49c6e2b7361..0d803841987 100644
--- a/toolkit/crashreporter/client/ping.cpp
+++ b/toolkit/crashreporter/client/ping.cpp
@@ -53,7 +53,7 @@ static string GenerateUUID() {
 
   CFRelease(uuid);
 #elif defined(HAVE_ARC4RANDOM_BUF)  // Android, BSD, ...
-  arc4random_buf(id, sizeof(UUID));
+  arc4random_buf(&id, sizeof(UUID));
 #else                               // Linux
   int fd = open("/dev/urandom", O_RDONLY);