From: Julien Grall <julien.grall@linaro.org>
Date: Mon, 16 Feb 2015 14:50:55 +0000 (+0000)
Subject: xen/arm: gic-v3: Update some comments in the code
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~3733
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=98e7c60d3ff1ce1cb14da528c37b53da02f6bc24;p=xen.git

xen/arm: gic-v3: Update some comments in the code

    - Drop wrong comment about the default stride. It's not always 2 * SZ_64K.
    When the re-distributor support VLPIs (from GICv4), the default
    stride is 4 * SZ_64K

    - Explain why SZ_64K * 2

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index e7a7789470..41042ab140 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -639,7 +639,7 @@ static int __init gicv3_populate_rdist(void)
                 ptr += gicv3.rdist_stride;
             else
             {
-                ptr += SZ_64K * 2;
+                ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */
                 if ( typer & GICR_TYPER_VLPIS )
                     ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
             }
@@ -1250,7 +1250,6 @@ static int __init gicv3_init(struct dt_device_node *node, const void *data)
     /* The vGIC code requires the region to be sorted */
     sort(rdist_regs, gicv3.rdist_count, sizeof(*rdist_regs), cmp_rdist, NULL);
 
-    /* If stride is not set in dt. Set default to 2 * SZ_64K */
     if ( !dt_property_read_u32(node, "redistributor-stride", &gicv3.rdist_stride) )
         gicv3.rdist_stride = 0;