From: Debian Science Team Date: Sun, 18 Feb 2024 20:31:18 +0000 (+0000) Subject: Fix test failures when xlsxwriter is not installed X-Git-Tag: archive/raspbian/2.2.3+dfsg-7+rpi1~1^2^2^2^2^2^2~5 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=97ef62bb9d4f639f0e48d06beca269e8ec0803fc;p=pandas.git Fix test failures when xlsxwriter is not installed Author: Rebecca N. Palmer Forwarded: no Gbp-Pq: Name 2p1_openpyxl_errors.patch --- diff --git a/pandas/tests/io/excel/test_openpyxl.py b/pandas/tests/io/excel/test_openpyxl.py index b8d41164..dc29e3de 100644 --- a/pandas/tests/io/excel/test_openpyxl.py +++ b/pandas/tests/io/excel/test_openpyxl.py @@ -115,13 +115,13 @@ def test_engine_kwargs_append_invalid(ext): DataFrame(["good"]).to_excel(writer, sheet_name="Sheet2") -@pytest.mark.parametrize("data_only, expected", [(True, 0), (False, "=1+1")]) +@pytest.mark.parametrize("data_only, expected", [(True, None), (False, "=1+1")]) def test_engine_kwargs_append_data_only(ext, data_only, expected): # GH 43445 # tests whether the data_only engine_kwarg actually works well for # openpyxl's load_workbook with tm.ensure_clean(ext) as f: - DataFrame(["=1+1"]).to_excel(f) + DataFrame(["=1+1"]).to_excel(f, engine="openpyxl") with ExcelWriter( f, engine="openpyxl", mode="a", engine_kwargs={"data_only": data_only} ) as writer: diff --git a/pandas/tests/io/excel/test_writers.py b/pandas/tests/io/excel/test_writers.py index 3ab703ea..5171737e 100644 --- a/pandas/tests/io/excel/test_writers.py +++ b/pandas/tests/io/excel/test_writers.py @@ -1308,6 +1308,8 @@ class TestExcelWriterEngineTests: assert isinstance(writer, _XlsxWriter) else: assert isinstance(writer, klass) + # openpyxl raises on closing if no sheets are written + DataFrame().to_excel(writer, sheet_name="Sheet1") def test_ExcelWriter_dispatch_raises(self): with pytest.raises(ValueError, match="No engine"):