From: Daniel Boles <dboles.src@gmail.com>
Date: Sun, 22 Apr 2018 20:17:29 +0000 (+0100)
Subject: MenuItem: Fix broken args to insert_before|after()
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~22^2~423
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=95f65da038c9f6615bacded2ff72bcfda1c502e7;p=gtk4.git

MenuItem: Fix broken args to insert_before|after()

The widget & its parent were swapped to each other’s place in the calls.

https://gitlab.gnome.org/GNOME/gtk/issues/200
---

diff --git a/gtk/gtkmenuitem.c b/gtk/gtkmenuitem.c
index 06867ab088..392de1e748 100644
--- a/gtk/gtkmenuitem.c
+++ b/gtk/gtkmenuitem.c
@@ -933,7 +933,7 @@ update_arrow_classes (GtkMenuItem *menu_item)
       child = gtk_widget_get_first_child (GTK_WIDGET (menu_item));
 
       if (child != priv->arrow_widget)
-        gtk_widget_insert_after (GTK_WIDGET (menu_item), priv->arrow_widget, NULL);
+        gtk_widget_insert_after (priv->arrow_widget, GTK_WIDGET (menu_item), NULL);
     }
   else
     {
@@ -943,7 +943,7 @@ update_arrow_classes (GtkMenuItem *menu_item)
       child = gtk_widget_get_last_child (GTK_WIDGET (menu_item));
 
       if (child != priv->arrow_widget)
-        gtk_widget_insert_before (GTK_WIDGET (menu_item), priv->arrow_widget, NULL);
+        gtk_widget_insert_before (priv->arrow_widget, GTK_WIDGET (menu_item), NULL);
     }
 }