From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Wed, 15 Mar 2023 15:18:15 +0000 (+0100)
Subject: Add informative messages after Q_ASSERTs for sockets in FileProviderSocketController... 
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~10^2~55^2~66
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=95c6e7a3f41028509498e80f08bed5839699adec;p=nextcloud-desktop.git

Add informative messages after Q_ASSERTs for sockets in FileProviderSocketController for release mode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/src/gui/macOS/fileprovidersocketcontroller.cpp b/src/gui/macOS/fileprovidersocketcontroller.cpp
index f3881c04f..8fd20fc95 100644
--- a/src/gui/macOS/fileprovidersocketcontroller.cpp
+++ b/src/gui/macOS/fileprovidersocketcontroller.cpp
@@ -53,6 +53,11 @@ void FileProviderSocketController::slotSocketDestroyed(const QObject * const obj
 void FileProviderSocketController::slotReadyRead()
 {
     Q_ASSERT(_socket);
+    if (!_socket) {
+        qCWarning(lcFileProviderSocketController) << "Cannot read data on dead socket";
+        return;
+    }
+
     while(_socket->canReadLine()) {
         const auto line = QString::fromUtf8(_socket->readLine().trimmed()).normalized(QString::NormalizationForm_C);
         qCDebug(lcFileProviderSocketController) << "Received message in file provider socket:" << line;
@@ -125,12 +130,22 @@ void FileProviderSocketController::sendMessage(const QString &message) const
 void FileProviderSocketController::start()
 {
     Q_ASSERT(_socket);
+    if (!_socket) {
+        qCWarning(lcFileProviderSocketController) << "Cannot start communication on dead socket";
+        return;
+    }
+
     requestFileProviderDomainInfo();
 }
 
 void FileProviderSocketController::requestFileProviderDomainInfo() const
 {
     Q_ASSERT(_socket);
+    if (!_socket) {
+        qCWarning(lcFileProviderSocketController) << "Cannot request file provider domain data on dead socket";
+        return;
+    }
+
     const auto requestMessage = QStringLiteral("SEND_FILE_PROVIDER_DOMAIN_IDENTIFIER");
     sendMessage(requestMessage);
 }