From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Fri, 30 Sep 2016 10:01:04 +0000 (+0100)
Subject: x86/emulate: Resolve MISSING_BREAK issue in x86_decode()
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~239
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=933acddf74213f77a5adbb2c10ccd3f72634d456;p=xen.git

x86/emulate: Resolve MISSING_BREAK issue in x86_decode()

Coverity doesn't appear to be able to spot that this is a terminal error path,
but leave a comment to "fix" MISSING_BREAK.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c
index 78b23a0caf..32e8b698df 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -1891,7 +1891,7 @@ x86_decode(
             switch ( def_ad_bytes )
             {
             default:
-                BUG();
+                BUG(); /* Shouldn't be possible. */
             case 2:
                 if ( in_realmode(ctxt, ops) || (state->regs->eflags & EFLG_VM) )
                     break;