From: Stefano Stabellini <sstabellini@kernel.org>
Date: Fri, 9 Dec 2016 00:59:28 +0000 (-0800)
Subject: missing vgic_unlock_rank in gic_remove_irq_from_guest
X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~3204
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=929afa7bcf14733884c0116e0c89783eaee42eee;p=xen.git

missing vgic_unlock_rank in gic_remove_irq_from_guest

Add missing vgic_unlock_rank on the error path in
gic_remove_irq_from_guest.

Coverity-ID: 1381843

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Julien Grall <julien.grall@arm.com>
---

diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 63c744af8a..a5348f237a 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -205,7 +205,10 @@ int gic_remove_irq_from_guest(struct domain *d, unsigned int virq,
          */
         if ( test_bit(_IRQ_INPROGRESS, &desc->status) ||
              !test_bit(_IRQ_DISABLED, &desc->status) )
+        {
+            vgic_unlock_rank(v_target, rank, flags);
             return -EBUSY;
+        }
     }
 
     clear_bit(_IRQ_GUEST, &desc->status);