From: Marcelo Ricardo Leitner Date: Wed, 28 Jul 2021 02:40:54 +0000 (-0300) Subject: sctp: fix return value check in __sctp_rcv_asconf_lookup X-Git-Tag: archive/raspbian/5.10.46-5+rpi1^2~40 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=91e905a783f34dfa109986a5d9eeb5cb10f81921;p=linux.git sctp: fix return value check in __sctp_rcv_asconf_lookup Origin: https://lore.kernel.org/linux-sctp/599e6c1fdcc50f16597380118c9b3b6790241d50.1627439903.git.marcelo.leitner@gmail.com/ As Ben Hutchings noticed, this check should have been inverted: the call returns true in case of success. Reported-by: Ben Hutchings Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return") Signed-off-by: Marcelo Ricardo Leitner Reviewed-by: Xin Long Gbp-Pq: Topic bugfix/all Gbp-Pq: Name sctp-fix-return-value-check-in-__sctp_rcv_asconf_loo.patch --- diff --git a/net/sctp/input.c b/net/sctp/input.c index f72bff93745..ddb5b5c2550 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1175,7 +1175,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( if (unlikely(!af)) return NULL; - if (af->from_addr_param(&paddr, param, peer_port, 0)) + if (!af->from_addr_param(&paddr, param, peer_port, 0)) return NULL; return __sctp_lookup_association(net, laddr, &paddr, transportp);