From: Kevin Ottens <kevin.ottens@nextcloud.com>
Date: Thu, 26 Nov 2020 18:08:17 +0000 (+0100)
Subject: Get DatabaseErrorTest to pass
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~21^2~468^2~432
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=9131a68ec4216e24b19cdfbbcffc089b85bb1674;p=nextcloud-desktop.git

Get DatabaseErrorTest to pass

The E2EE code path would get the engine to go wrong in case of db error.
It's just better to have a failing upload or failing mkdir later in those
cases.

Emitting signals from a ctor is a bad idea anyway

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
---

diff --git a/src/libsync/propagateremotemkdir.cpp b/src/libsync/propagateremotemkdir.cpp
index d2fd73700..d1ac78aef 100644
--- a/src/libsync/propagateremotemkdir.cpp
+++ b/src/libsync/propagateremotemkdir.cpp
@@ -49,7 +49,6 @@ PropagateRemoteMkdir::PropagateRemoteMkdir(OwncloudPropagator *propagator, const
     SyncJournalFileRecord parentRec;
     bool ok = propagator->_journal->getFileRecord(parentPath, &parentRec);
     if (!ok) {
-        done(SyncFileItem::NormalError);
         return;
     }
 
diff --git a/src/libsync/propagateupload.cpp b/src/libsync/propagateupload.cpp
index dd67be3ae..7211f4fba 100644
--- a/src/libsync/propagateupload.cpp
+++ b/src/libsync/propagateupload.cpp
@@ -189,7 +189,6 @@ PropagateUploadFileCommon::PropagateUploadFileCommon(OwncloudPropagator *propaga
     SyncJournalFileRecord parentRec;
     bool ok = propagator->_journal->getFileRecord(parentPath, &parentRec);
     if (!ok) {
-        done(SyncFileItem::NormalError);
         return;
     }