From: Hans van Kranenburg <hans@knorrie.org>
Date: Mon, 7 Sep 2020 00:19:40 +0000 (+0200)
Subject: d/xen-utils-V.lintian-overrides.vsn-in: fix rpath override
X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~43
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=90e2371d5f7e77968dfa71bd102e2ea98cb6efa8;p=xen.git

d/xen-utils-V.lintian-overrides.vsn-in: fix rpath override

Lintian complains:

    E: xen-utils-4.14: custom-library-search-path usr/lib/xen-4.14/lib/python/xenfsimage.cpython-38-x86_64-linux-gnu.so /usr/lib/xen-4.14/lib/x86_64-linux-gnu
    N:
    N:    The binary or shared library sets RPATH or RUNPATH. This overrides the
    N:    normal library search path, possibly interfering with local policy and
    N:    causing problems for multilib, among other issues.
    N:
    N:    The only time a binary or shared library in a Debian package should set
    N:    RPATH or RUNPATH is if it is linked to private shared libraries in the
    N:    same package. In that case, place those private shared libraries in
    N:    /usr/lib/<package>. Libraries used by binaries in other packages should
    N:    be placed in /lib or /usr/lib as appropriate, with a proper SONAME, in
    N:    which case RPATH/RUNPATH is unnecessary.
    N:
    N:    To fix this problem, look for link lines like:
    N:        gcc test.o -o test -Wl,--rpath,/usr/local/lib
    N:    or
    N:        gcc test.o -o test -R/usr/local/lib
    N:    and remove the -Wl,--rpath or -R argument. You can also use the chrpath
    N:    utility to remove the RPATH.
    N:
    N:    Refer to https://wiki.debian.org/RpathIssue for details.
    N:
    N:    Severity: error
    N:
    N:    Check: binaries

    W: xen-utils-4.14: mismatched-override custom-library-search-path usr/lib/xen-4.14/lib/python/xenfsimage.so /usr/lib/xen-4.14/lib/x86_64-linux-gnu
    N:
    N:    The named tag could have been silenced but the context specified with
    N:    the override did not match.
    N:
    N:    Lintian may now provide a different context for the tag, or something
    N:    could have changed in a new version of your package. Either way,
    N:    overrides work best when you require only little context.
    N:
    N:    You can use wildcards, such as &ast; or &quest; in the context to makes
    N:    a match more likely.
    N:
    N:    Please remove or adjust the override, whichever suits your purpose.
    N:
    N:    Severity: warning
    N:
    N:    Check: lintian

The target file has a new name, with cpython-blurb in it. Wildcard that
part.

Signed-off-by: Hans van Kranenburg <hans@knorrie.org>
---

diff --git a/debian/xen-utils-V.lintian-overrides.vsn-in b/debian/xen-utils-V.lintian-overrides.vsn-in
index 0f2ecf8253..745631ddcd 100644
--- a/debian/xen-utils-V.lintian-overrides.vsn-in
+++ b/debian/xen-utils-V.lintian-overrides.vsn-in
@@ -8,6 +8,6 @@ binary-has-unneeded-section usr/lib/xen-@version@/boot/xen-shim .note
 binary-from-other-architecture usr/lib/debug/xen-syms-@version@-shim/xen-shim-syms
 # ^ this is a symbols file for the shim
 
-binary-or-shlib-defines-rpath usr/lib/xen-@version@/lib/python/xenfsimage.so /usr/lib/xen-@version@/lib/x86_64-linux-gnu
+binary-or-shlib-defines-rpath usr/lib/xen-@version@/lib/python/xenfsimage.*.so /usr/lib/xen-@version@/lib/x86_64-linux-gnu
 # ^ this module needs to load the libfsimage .so from within
 #   the xen-utils private directory.  less +/fsimage debian/rules