From: Matthias Clasen <mclasen@redhat.com>
Date: Wed, 8 Jul 2015 03:16:09 +0000 (-0400)
Subject: places sidebar: Fix rows getting 'lost' when dnd fails
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~24^2~9098
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=8e53a011885adc749dc67e3553f21f9fbe4404e3;p=gtk4.git

places sidebar: Fix rows getting 'lost' when dnd fails

There was some code that lead to the places sidebar loosing track
of the row being dragged if a motion event came in between letting
go of the button and the drag snap-back animation ending. This would
cause us to not show the row again, giving the appearance that it
was 'lost'.

https://bugzilla.gnome.org/show_bug.cgi?id=751448
---

diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index a591ea5da3..322b7f1542 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -1456,11 +1456,7 @@ on_motion_notify_event (GtkWidget      *widget,
     return FALSE;
 
   if (!(event->state & GDK_BUTTON1_MASK))
-    {
-      sidebar->drag_row = NULL;
-
-      return FALSE;
-    }
+    return FALSE;
 
   if (gtk_drag_check_threshold (widget,
                                 sidebar->drag_root_x, sidebar->drag_root_y,