From: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Date: Thu, 14 Sep 2023 09:58:00 +0000 (+0200)
Subject: once we call done on a sync file item, return is needed
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~9^2~4^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=8d68218bd73a0bc9d437eb7784ac16c5a61481bf;p=nextcloud-desktop.git

once we call done on a sync file item, return is needed

will avoid calling done method multiple times on a signle file item
causing a crash via ENFORCE function

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
---

diff --git a/src/libsync/propagatedownload.cpp b/src/libsync/propagatedownload.cpp
index 08ab48489..8b78b2ab9 100644
--- a/src/libsync/propagatedownload.cpp
+++ b/src/libsync/propagatedownload.cpp
@@ -1226,6 +1226,7 @@ void PropagateDownloadFile::downloadFinished()
             QString error;
             if (!propagator()->createConflict(_item, _associatedComposite, &error)) {
                 done(SyncFileItem::SoftError, error, ErrorCategory::GenericError);
+                return;
             } else {
                 previousFileExists = false;
             }