From: Philip Withnall <pwithnall@endlessos.org>
Date: Tue, 8 Mar 2022 15:36:27 +0000 (+0000)
Subject: ostree-repo-pull: Take correct out path on error
X-Git-Tag: archive/raspbian/2022.4-1+rpi1^2~9^2~1^2~17^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=8cc8e687683f363f070b900c8ab7bc913d5c83b7;p=ostree.git

ostree-repo-pull: Take correct out path on error

Like every other error return path in this function, jump to the `out`
label on error here. Returning directly will cause leaks.

Spotted by reading the code, not actually necessarily encountered in the
wild.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
---

diff --git a/src/libostree/ostree-repo-pull.c b/src/libostree/ostree-repo-pull.c
index e8918cf6..1d61faaf 100644
--- a/src/libostree/ostree-repo-pull.c
+++ b/src/libostree/ostree-repo-pull.c
@@ -4020,7 +4020,7 @@ ostree_repo_pull_with_options (OstreeRepo             *self,
                                      &pull_data->signapi_commit_verifiers,
                                      &pull_data->signapi_summary_verifiers,
                                      error))
-        return FALSE;
+        goto out;
     }
 
   pull_data->phase = OSTREE_PULL_PHASE_FETCHING_REFS;