From: Benjamin Otte <otte@redhat.com>
Date: Fri, 3 Mar 2023 02:05:22 +0000 (+0100)
Subject: columnview: Clear the sorter first thing in dispose
X-Git-Tag: archive/raspbian/4.12.3+ds-1+rpi1~1^2^2^2~22^2~5^2~61^2~2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=882dcda53b51b10299896efe075d177e9df3458c;p=gtk4.git

columnview: Clear the sorter first thing in dispose

Otherwise, when removing the columns, each column will trigger a
sorter::changed signal emission.

And because sorters are often still connected to a sortlistmodel, we
can't skip that emission and need to do it.
But we only need to do it once.
---

diff --git a/gtk/gtkcolumnview.c b/gtk/gtkcolumnview.c
index 95fb02d8eb..33fe678c8e 100644
--- a/gtk/gtkcolumnview.c
+++ b/gtk/gtkcolumnview.c
@@ -477,6 +477,8 @@ gtk_column_view_dispose (GObject *object)
 {
   GtkColumnView *self = GTK_COLUMN_VIEW (object);
 
+  gtk_column_view_sorter_clear (GTK_COLUMN_VIEW_SORTER (self->sorter));
+
   while (g_list_model_get_n_items (G_LIST_MODEL (self->columns)) > 0)
     {
       GtkColumnViewColumn *column = g_list_model_get_item (G_LIST_MODEL (self->columns), 0);