From: Olivier Goffart Date: Thu, 7 Jan 2016 13:58:02 +0000 (+0100) Subject: HttpCredentials::slotAuthentication: fix comment X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~1254^2~95 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=81b7798ac220c8a3413a7f4e4ed6c80f1d89a0fc;p=nextcloud-desktop.git HttpCredentials::slotAuthentication: fix comment The recent revert did no fix the comment --- diff --git a/src/libsync/creds/httpcredentials.cpp b/src/libsync/creds/httpcredentials.cpp index d30c009f0..fbe78fadd 100644 --- a/src/libsync/creds/httpcredentials.cpp +++ b/src/libsync/creds/httpcredentials.cpp @@ -308,9 +308,8 @@ void HttpCredentials::slotWriteJobDone(QKeychain::Job *job) void HttpCredentials::slotAuthentication(QNetworkReply* reply, QAuthenticator* authenticator) { Q_UNUSED(authenticator) - // we cannot use QAuthenticator, because it sends username and passwords with latin1 - // instead of utf8 encoding. Instead, we send it manually. Thus, if we reach this signal, - // those credentials were invalid and we terminate. + // Because of issue #4326, we need to set the login and password manually at every requests + // Thus, if we reach this signal, those credentials were invalid and we terminate. qDebug() << "Stop request: Authentication failed for " << reply->url().toString(); reply->setProperty(authenticationFailedC, true); reply->close();