From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Thu, 11 May 2023 12:13:39 +0000 (+0800)
Subject: Don't bother creating a unique ptr for computeChecksum as we never use the guarded ptr
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~10^2~51^2~10
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=811a4036cb1e177f2cb64ec39e90b7564a493634;p=nextcloud-desktop.git

Don't bother creating a unique ptr for computeChecksum as we never use the guarded ptr
---

diff --git a/src/libsync/bulkpropagatorjob.cpp b/src/libsync/bulkpropagatorjob.cpp
index dab9f9846..450d09e9c 100644
--- a/src/libsync/bulkpropagatorjob.cpp
+++ b/src/libsync/bulkpropagatorjob.cpp
@@ -260,20 +260,16 @@ void BulkPropagatorJob::slotComputeTransmissionChecksum(SyncFileItemPtr item,
                                                         UploadFileInfo fileToUpload)
 {
     // Compute the transmission checksum.
-    auto computeChecksum = std::make_unique<ComputeChecksum>(this);
-    if (uploadChecksumEnabled()) {
-        computeChecksum->setChecksumType("MD5" /*propagator()->account()->capabilities().uploadChecksumType()*/);
-    } else {
-        computeChecksum->setChecksumType(QByteArray());
-    }
+    const auto computeChecksum = new ComputeChecksum(this);
+    const auto checksumType = uploadChecksumEnabled() ? "MD5" : "";
+    computeChecksum->setChecksumType(checksumType);
 
-    connect(computeChecksum.get(), &ComputeChecksum::done,
-            this, [this, item, fileToUpload] (const QByteArray &contentChecksumType, const QByteArray &contentChecksum) {
+    connect(computeChecksum, &ComputeChecksum::done, this, [this, item, fileToUpload] (const QByteArray &contentChecksumType, const QByteArray &contentChecksum) {
         slotStartUpload(item, fileToUpload, contentChecksumType, contentChecksum);
     });
-    connect(computeChecksum.get(), &ComputeChecksum::done,
-            computeChecksum.get(), &QObject::deleteLater);
-    computeChecksum.release()->start(fileToUpload._path);
+    connect(computeChecksum, &ComputeChecksum::done, computeChecksum, &QObject::deleteLater);
+
+    computeChecksum->start(fileToUpload._path);
 }
 
 void BulkPropagatorJob::slotStartUpload(SyncFileItemPtr item,