From: Wei Liu <wei.liu2@citrix.com>
Date: Fri, 29 Apr 2016 15:11:16 +0000 (+0100)
Subject: blktap2: initialise buf to NULL in img2qcow.c:main
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1149
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=7e2a1f9402b088c5bf62ceb157e7ea6dfe8196f0;p=xen.git

blktap2: initialise buf to NULL in img2qcow.c:main

Gcc complains:

qcow2raw.c: In function ‘main’:
qcow2raw.c:387:17: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    treq.buf     = buf;
                 ^

But at the point of that assignment, buf is a valid buffer allocated by
posix_memalign and filled in by read.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
---

diff --git a/tools/blktap2/drivers/img2qcow.c b/tools/blktap2/drivers/img2qcow.c
index 57b931e551..7376382dcf 100644
--- a/tools/blktap2/drivers/img2qcow.c
+++ b/tools/blktap2/drivers/img2qcow.c
@@ -166,7 +166,7 @@ int main(int argc, const char *argv[])
         int ret = -1, fd, len, err;
 	struct timeval timeout;
 	uint64_t i;
-	char *buf;
+	char *buf = NULL;
 	td_request_t treq;
         td_disk_info_t info;
         td_vbd_request_t* vreq;