From: Jan Beulich Date: Mon, 26 Sep 2016 15:20:36 +0000 (+0200) Subject: VMX: don't bypass vmx_update_secondary_exec_control() X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~350 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=7c8004ef0cb699320161e2bb3bb10bafadd3f8d4;p=xen.git VMX: don't bypass vmx_update_secondary_exec_control() While putting together another patch modifying the secondary exec controls I noticed that vmx_vcpu_update_vmfunc_ve() does a raw VMWRITE instead of going through the designated function. I assume that is not how it should be. Signed-off-by: Jan Beulich Acked-by: Kevin Tian --- diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 50cbfed4dc..b9102cebed 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2062,9 +2062,7 @@ static void vmx_vcpu_update_vmfunc_ve(struct vcpu *v) else v->arch.hvm_vmx.secondary_exec_control &= ~mask; - __vmwrite(SECONDARY_VM_EXEC_CONTROL, - v->arch.hvm_vmx.secondary_exec_control); - + vmx_update_secondary_exec_control(v); vmx_vmcs_exit(v); }