From: robertlipe <robertlipe@f51c46e8-681c-474f-0cfe-069cfd0219fb>
Date: Sun, 13 Apr 2014 03:37:55 +0000 (+0000)
Subject: Well, isn't this fun?  The newly added Garmin format overlows an internal
X-Git-Tag: archive/raspbian/1.10.0+ds-2+rpi1~1^2~12^2~11^2~153
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=7aa32ad81e36b58957dee9f989e6ae8fd9c15f91;p=gpsbabel.git

Well, isn't this fun?  The newly added Garmin format overlows an internal
hardcoded buffer when we format our help options, such as we do when
we make doc...like one does when trying to make a release.  Argh!
---

diff --git a/gpsbabel/xcsv.cc b/gpsbabel/xcsv.cc
index b1d9e84cb..88cf49ea5 100644
--- a/gpsbabel/xcsv.cc
+++ b/gpsbabel/xcsv.cc
@@ -515,7 +515,9 @@ xcsv_parse_style_line(char* sbuff)
 static void
 xcsv_parse_style_buff(const char* sbuff)
 {
-  char ibuf[256];
+  // FIXME: should not be a static buf.  Should not be a raw character
+  // buffer at all!
+  char ibuf[4096];
   char* ibufp;
   size_t i;