From: Jan Beulich <jbeulich@suse.com>
Date: Thu, 13 Apr 2017 15:35:02 +0000 (+0200)
Subject: x86/vIO-APIC: fix uninitialized variable warning
X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~2229
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=7a481bfa4f6a623e87a4bac3b50a5ef5924d9f2c;p=xen.git

x86/vIO-APIC: fix uninitialized variable warning

In a release build modern gcc validly complains about "pin" possibly
being uninitialized in vioapic_irq_positive_edge().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Julien Grall <julien.grall@arm.com>
---

diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c
index 52555cd328..5157db7a4e 100644
--- a/xen/arch/x86/hvm/vioapic.c
+++ b/xen/arch/x86/hvm/vioapic.c
@@ -421,7 +421,11 @@ void vioapic_irq_positive_edge(struct domain *d, unsigned int irq)
     struct hvm_vioapic *vioapic = gsi_vioapic(d, irq, &pin);
     union vioapic_redir_entry *ent;
 
-    ASSERT(vioapic);
+    if ( !vioapic )
+    {
+        ASSERT_UNREACHABLE();
+        return;
+    }
 
     HVM_DBG_LOG(DBG_LEVEL_IOAPIC, "irq %x", irq);