From: Jan Beulich <jbeulich@suse.com>
Date: Tue, 4 Jan 2022 09:20:15 +0000 (+0100)
Subject: libxc: avoid clobbering errno in xc_domain_pod_target()
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~1171
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=78688ffa7e86e7cdb57d383e213fd822aaaa5438;p=xen.git

libxc: avoid clobbering errno in xc_domain_pod_target()

do_memory_op() supplies return value and has "errno" set the usual way.
Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
also no reason to overwrite "err".

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---

diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 20b86d986c..ef62f66009 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1230,13 +1230,9 @@ static int xc_domain_pod_target(xc_interface *xch,
     err = do_memory_op(xch, op, &pod_target, sizeof(pod_target));
 
     if ( err < 0 )
-    {
         DPRINTF("Failed %s_pod_target dom %d\n",
                 (op==XENMEM_set_pod_target)?"set":"get",
                 domid);
-        errno = -err;
-        err = -1;
-    }
     else
         err = 0;