From: Benjamin Otte <otte@redhat.com>
Date: Sat, 23 Nov 2019 18:01:28 +0000 (+0100)
Subject: cssprovider: Don't add empty rulesets
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~20^2~605
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=7523a3f2f2eed7e4b42113d94c0018f802fd7ed5;p=gtk4.git

cssprovider: Don't add empty rulesets

This change was lost during the parser changes, but the newly added test
exposes it.

And fix the expected error, the syntax has changed.
---

diff --git a/gtk/gtkcssprovider.c b/gtk/gtkcssprovider.c
index 1aae733d27..5c4c6e9e2e 100644
--- a/gtk/gtkcssprovider.c
+++ b/gtk/gtkcssprovider.c
@@ -631,6 +631,12 @@ css_provider_commit (GtkCssProvider *css_provider,
   GtkCssProviderPrivate *priv = gtk_css_provider_get_instance_private (css_provider);
   GSList *l;
 
+  if (ruleset->styles == NULL)
+    {
+      g_slist_free_full (selectors, (GDestroyNotify) _gtk_css_selector_free);
+      return;
+    }
+
   for (l = selectors; l; l = l->next)
     {
       GtkCssRuleset new;
diff --git a/testsuite/css/parser/border-crash-3.24.errors b/testsuite/css/parser/border-crash-3.24.errors
index c49f1d071a..f7b815aaf5 100644
--- a/testsuite/css/parser/border-crash-3.24.errors
+++ b/testsuite/css/parser/border-crash-3.24.errors
@@ -1 +1 @@
-border-crash-3.24.css:3: error: GTK_CSS_PROVIDER_ERROR_SYNTAX
+border-crash-3.24.css:3:3-10: error: GTK_CSS_PARSER_ERROR_SYNTAX