From: Roger Pau Monné Date: Wed, 12 Aug 2020 12:47:05 +0000 (+0200) Subject: x86/hvm: change EOI exit bitmap helper parameter X-Git-Tag: archive/raspbian/4.16.0+51-g0941d6cb-1+rpi1~2^2~42^2~1771 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=74ac7c81788198342d1dd60f95fa4870fa64728e;p=xen.git x86/hvm: change EOI exit bitmap helper parameter Change the last parameter of the update_eoi_exit_bitmap helper to be a set/clear boolean instead of a triggering field. This is already inline with how the function is implemented, and will allow deciding whether an exit is required by the higher layers that call into update_eoi_exit_bitmap. Note that the current behavior is not changed by this patch. No functional change intended. Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper Reviewed-by: Kevin Tian --- diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 86799c24ba..a0d58ffbe2 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1885,9 +1885,9 @@ static void vmx_set_info_guest(struct vcpu *v) vmx_vmcs_exit(v); } -static void vmx_update_eoi_exit_bitmap(struct vcpu *v, u8 vector, u8 trig) +static void vmx_update_eoi_exit_bitmap(struct vcpu *v, uint8_t vector, bool set) { - if ( trig ) + if ( set ) vmx_set_eoi_exit_bitmap(v, vector); else vmx_clear_eoi_exit_bitmap(v, vector); diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h index 1eb377dd82..be0d8b0a4d 100644 --- a/xen/include/asm-x86/hvm/hvm.h +++ b/xen/include/asm-x86/hvm/hvm.h @@ -192,7 +192,7 @@ struct hvm_function_table { void (*nhvm_domain_relinquish_resources)(struct domain *d); /* Virtual interrupt delivery */ - void (*update_eoi_exit_bitmap)(struct vcpu *v, u8 vector, u8 trig); + void (*update_eoi_exit_bitmap)(struct vcpu *v, uint8_t vector, bool set); void (*process_isr)(int isr, struct vcpu *v); void (*deliver_posted_intr)(struct vcpu *v, u8 vector); void (*sync_pir_to_irr)(struct vcpu *v);