From: Wolf Vollprecht <w.vollprecht@gmail.com>
Date: Thu, 6 Jan 2022 08:03:03 +0000 (+0100)
Subject: fix up get_tmp_fd for windows
X-Git-Tag: archive/raspbian/1.2.1+ds1-1+rpi1^2~7^2~1^2~10^2~15
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=740373795c387864160b14d6069d063ff6b97920;p=zchunk.git

fix up get_tmp_fd for windows
---

diff --git a/src/lib/win32/basename.c b/src/lib/win32/basename.c
index 0d6a8e5..61ae8a3 100644
--- a/src/lib/win32/basename.c
+++ b/src/lib/win32/basename.c
@@ -3,6 +3,10 @@
 
 char* basename(char* path)
 {
+    // note this is not a proper basename implementation
+    char *p = strrchr (path, '\\');
+    return p ? p + 1 : (char *) path;
+
     // char full_path[MAX_PATH], drive[MAX_PATH], dir[MAX_PATH], filename[MAX_PATH], ext[MAX_PATH];
 
     // printf("Input: %s", path);
@@ -17,8 +21,6 @@ char* basename(char* path)
     // const char* res = malloc(MAX_PATH);
     // sprintf(res, "%s%s", filename, ext);
     // printf("Result: %s", res);
-    char *p = strrchr (path, '\\');
-    return p ? p + 1 : (char *) path;
 
     // return res;
 }
\ No newline at end of file
diff --git a/src/lib/zck.c b/src/lib/zck.c
index a256dff..3e6571b 100644
--- a/src/lib/zck.c
+++ b/src/lib/zck.c
@@ -147,7 +147,12 @@ int get_tmp_fd(zckCtx *zck) {
     int temp_fd;
     char *fname = NULL;
     char template[] = "zcktempXXXXXX";
+
+    #ifdef _WIN32
+    char *tmpdir = getenv("TEMP");
+    #else
     char *tmpdir = getenv("TMPDIR");
+    #endif
 
     if(tmpdir == NULL) {
         tmpdir = "/tmp/";
@@ -165,7 +170,11 @@ int get_tmp_fd(zckCtx *zck) {
     for(i=0; i<strlen(tmpdir); i++)
         fname[i] = tmpdir[i];
     int offset = i;
+    #ifdef _WIN32
+    fname[offset] = '\\';
+    #else
     fname[offset] = '/';
+    #endif
     offset++;
     for(i=0; i<strlen(template); i++)
         fname[offset + i] = template[i];
@@ -178,9 +187,9 @@ int get_tmp_fd(zckCtx *zck) {
     #ifdef _WIN32
     errno_t out = _mktemp_s(
         fname,
-        offset
+        offset + 1
     );
-    temp_fd = open(fname);
+    temp_fd = open(fname, O_CREAT | O_EXCL | O_RDWR | O_BINARY);
     #else
     old_mode_mask = umask (S_IXUSR | S_IRWXG | S_IRWXO);
     temp_fd = mkstemp(fname);
@@ -191,11 +200,14 @@ int get_tmp_fd(zckCtx *zck) {
         set_error(zck, "Unable to create temporary file");
         return -1;
     }
+#ifndef _WIN32
+    // Files with open file handle cannot be removed on Windows
     if(unlink(fname) < 0) {
         free(fname);
         set_error(zck, "Unable to delete temporary file");
         return -1;
     }
+#endif
     free(fname);
     return temp_fd;
 }