From: Kaustubh Welankar <kaustubh.welankar@hotmail.com>
Date: Thu, 20 Apr 2017 09:14:53 +0000 (+0530)
Subject: Removed Magic Numbers in propagator #5685 (#5705)
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~768
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=70c35149968c0601f78783f94e7206baf67af365;p=nextcloud-desktop.git

Removed Magic Numbers in propagator #5685 (#5705)
---

diff --git a/src/libsync/owncloudpropagator.cpp b/src/libsync/owncloudpropagator.cpp
index 232984e04..99e5ca016 100644
--- a/src/libsync/owncloudpropagator.cpp
+++ b/src/libsync/owncloudpropagator.cpp
@@ -392,6 +392,12 @@ PropagateItemJob* OwncloudPropagator::createJob(const SyncFileItemPtr &item) {
     return 0;
 }
 
+quint64 OwncloudPropagator::smallFileSize()
+{
+    const quint64 smallFileSize = 100*1024; //default to 1 MB. Not dynamic right now.
+    return smallFileSize;
+}
+
 void OwncloudPropagator::start(const SyncFileItemVector& items)
 {
     Q_ASSERT(std::is_sorted(items.begin(), items.end()));
diff --git a/src/libsync/owncloudpropagator.h b/src/libsync/owncloudpropagator.h
index b2a57f7da..461105000 100644
--- a/src/libsync/owncloudpropagator.h
+++ b/src/libsync/owncloudpropagator.h
@@ -327,6 +327,7 @@ public:
      * chunk-upload duration set.
      */
     quint64 _chunkSize;
+    quint64 smallFileSize();
 
     /* The maximum number of active jobs in parallel  */
     int hardMaximumActiveJob();
diff --git a/src/libsync/propagatedownload.h b/src/libsync/propagatedownload.h
index 6553760cb..437e7a514 100644
--- a/src/libsync/propagatedownload.h
+++ b/src/libsync/propagatedownload.h
@@ -115,7 +115,7 @@ public:
     qint64 committedDiskSpace() const Q_DECL_OVERRIDE;
 
     // We think it might finish quickly because it is a small file.
-    bool isLikelyFinishedQuickly() Q_DECL_OVERRIDE { return _item->_size < 100*1024; }
+    bool isLikelyFinishedQuickly() Q_DECL_OVERRIDE { return _item->_size < propagator()->smallFileSize(); }
 
     /**
      * Whether an existing folder with the same name may be deleted before
diff --git a/src/libsync/propagateupload.h b/src/libsync/propagateupload.h
index 969b6709a..bebd70dce 100644
--- a/src/libsync/propagateupload.h
+++ b/src/libsync/propagateupload.h
@@ -212,7 +212,7 @@ public:
 
     void start() Q_DECL_OVERRIDE;
 
-    bool isLikelyFinishedQuickly() Q_DECL_OVERRIDE { return _item->_size < 100*1024; }
+    bool isLikelyFinishedQuickly() Q_DECL_OVERRIDE { return _item->_size < propagator()->smallFileSize(); }
 
 private slots:
     void slotComputeContentChecksum();