From: Roger Pau Monné <roger.pau@citrix.com>
Date: Fri, 10 Feb 2017 09:42:47 +0000 (+0100)
Subject: x86/iommu: add missing break
X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~2821
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=6f6d3b10ec8168e2a78cf385d89803397f116397;p=xen.git

x86/iommu: add missing break

50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
adding IOMMU entries for p2m_mmio_direct regions.

Spotted by Coverity.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 173a6f825a..c68ff589e1 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt, mfn_t mfn)
         flags = IOMMUF_readable;
         if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
             flags |= IOMMUF_writable;
+        break;
     default:
         flags = 0;
         break;