From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Mon, 4 Apr 2016 14:18:03 +0000 (+0100)
Subject: libxl: Set rc on failure of usbdev_busaddr_to_busid
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1342
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=6c4bf5aec69f757d1cf7e76043b460e83317e2f4;p=xen.git

libxl: Set rc on failure of usbdev_busaddr_to_busid

We must set rc before using `goto out'.

Bug introduced in bf7628f0 "libxl: add pvusb API".

CID: 1358113
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: coverity@xenproject.org
CC: Simon Cao <caobosimon@gmail.com>
CC: George Dunlap <george.dunlap@citrix.com>
Reviewed-by: Chunyan Liu <cyliu@suse.com>
---

diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
index f69792a12c..07030a4bc3 100644
--- a/tools/libxl/libxl_pvusb.c
+++ b/tools/libxl/libxl_pvusb.c
@@ -964,6 +964,7 @@ static int libxl__device_usbdev_add_xenstore(libxl__gc *gc, uint32_t domid,
                                     usbdev->u.hostdev.hostaddr);
     if (!busid) {
         LOG(DEBUG, "Fail to get busid of usb device");
+        rc = ERROR_FAIL;
         goto out;
     }