From: Jan Beulich <jbeulich@suse.com>
Date: Thu, 13 Jan 2022 13:32:34 +0000 (+0100)
Subject: build: correct usage comments in Kbuild.include
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~1156
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=6bce8cc00594f41830739b76e367423fd4e7444d;p=xen.git

build: correct usage comments in Kbuild.include

Macros with arguments need to be invoked via $(call ...); don't misguide
people looking up usage of such macros.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/xen/scripts/Kbuild.include b/xen/scripts/Kbuild.include
index 83c7e1457b..f75d724ed7 100644
--- a/xen/scripts/Kbuild.include
+++ b/xen/scripts/Kbuild.include
@@ -43,15 +43,15 @@ define as-option-add-closure
     endif
 endef
 
-# $(if-success,<command>,<then>,<else>)
+# $(call if-success,<command>,<then>,<else>)
 # Return <then> if <command> exits with 0, <else> otherwise.
 if-success = $(shell { $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)")
 
-# $(success,<command>)
+# $(call success,<command>)
 # Return y if <command> exits with 0, n otherwise
 success = $(call if-success,$(1),y,n)
 
-# $(ld-option,<flag>)
+# $(call ld-option,<flag>)
 # Return y if the linker supports <flag>, n otherwise
 ld-option = $(call success,$(LD) -v $(1))