From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Tue, 17 Jan 2023 20:14:33 +0000 (-0700)
Subject: macOS brew install fix (#986)
X-Git-Tag: archive/raspbian/1.10.0+ds-2+rpi1~1^2~12^2~1^2~130
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=67854361ade9388fc3cb2145e45dffb249ca95a7;p=gpsbabel.git

macOS brew install fix (#986)

* optimize brew install time.

* try skipping brew update to speed up install

* is jing-trang really the problem?

* skip relink step

* avoid brew python link issues and dependency upgrades.

This cuts the brew install time down about 10x.
---

diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index 7de263fee..cdf275c27 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -61,17 +61,13 @@ jobs:
     - name: Brew install
       if: matrix.GENERATOR == 'Ninja'
       run: |
-        # homebrew fails to update python from 3.9 to 3.10 due
-        # to another unlinking failure. See hack at brew upgrade
-        rm -f /usr/local/bin/2to3 /usr/local/bin/idle3 \
-          /usr/local/bin/idle3 /usr/local/bin/pydoc3 \
-          /usr/local/bin/python3 /usr/local/bin/python3-config
-        brew update
-        # From https://github.com/actions/runner-images/issues/6817#issuecomment-1363382175
-        # a topic that's flaming right now, though this is a recurring
-        # problem as described in
-        # https://github.com/actions/runner-images/issues/4020
-        brew upgrade || true
+        # update/upgrade is causing issues
+        # https://github.com/orgs/Homebrew/discussions/3895
+        # https://github.com/actions/setup-python/issues/577
+        # https://github.com/actions/runner-images/issues/6459
+        # https://github.com/actions/runner-images/issues/6507
+        # https://github.com/actions/runner-images/issues/2322
+        # brew update # skip update for now to avoid link issues AND many slow dependency upGRADES.
         brew install ninja
         brew install docbook docbook-xsl fop gnu-sed
         brew install jing-trang