From: Jan Beulich Date: Wed, 12 Jun 2013 08:07:48 +0000 (+0200) Subject: io/ring.h: drop unused and broken *_RING_ATTACH() macros X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6752 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=613659da9b1755ddf0a291071f6551a0ad25419b;p=xen.git io/ring.h: drop unused and broken *_RING_ATTACH() macros Initializing r*_prod_pvt and r*_cons from independent shared ring fields is broken, as other macros in this header rely on them being coupled. Furthermore using the backend variant would also imply a security vulnerability. Signed-off-by: Jan Beulich Acked-by: Keir Fraser --- diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h index bdfb998cec..73e13d7ae4 100644 --- a/xen/include/public/io/ring.h +++ b/xen/include/public/io/ring.h @@ -174,21 +174,6 @@ typedef struct __name##_back_ring __name##_back_ring_t (_r)->sring = (_s); \ } while (0) -/* Initialize to existing shared indexes -- for recovery */ -#define FRONT_RING_ATTACH(_r, _s, __size) do { \ - (_r)->sring = (_s); \ - (_r)->req_prod_pvt = (_s)->req_prod; \ - (_r)->rsp_cons = (_s)->rsp_prod; \ - (_r)->nr_ents = __RING_SIZE(_s, __size); \ -} while (0) - -#define BACK_RING_ATTACH(_r, _s, __size) do { \ - (_r)->sring = (_s); \ - (_r)->rsp_prod_pvt = (_s)->rsp_prod; \ - (_r)->req_cons = (_s)->req_prod; \ - (_r)->nr_ents = __RING_SIZE(_s, __size); \ -} while (0) - /* How big is this ring? */ #define RING_SIZE(_r) \ ((_r)->nr_ents)