From: Hans van Kranenburg <hans@knorrie.org>
Date: Sat, 16 Jan 2021 18:56:04 +0000 (+0100)
Subject: d/shuffle-boot-files: Document more inner workings
X-Git-Tag: archive/raspbian/4.14.1+11-gb0b734a8b3-1+rpi1^2~47
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=611ee816a4dca845d4bf3806725254b65d805cb7;p=xen.git

d/shuffle-boot-files: Document more inner workings

This script looks quite cryptic if one is not aware of the actual values
that are thrown around between the different commands. Make it easier to
understand what's happening when reading it for the first time.

Signed-off-by: Hans van Kranenburg <hans@knorrie.org>
---

diff --git a/debian/shuffle-boot-files b/debian/shuffle-boot-files
index 5268c2879b..67fb768223 100755
--- a/debian/shuffle-boot-files
+++ b/debian/shuffle-boot-files
@@ -10,22 +10,29 @@ hv="xen-hypervisor-$version-$flavour"
 dest="debian/$hv/boot"
 mkdir -p "$dest"
 
-# The upstream build system puts a pile of needless symlinks in /boot.
+# The upstream build system puts a pile of needless symlinks in /boot,
+# like 'xen-4.14.gz', 'xen-4.gz' and 'xen.gz' or even just 'xen'.
 #
-# Conversely it gives the actual hypervisor binary an unhelpfully-varying
-# name.  It makes symlinks with more stable names, which we can use
-# to our advantage.
+# Conversely it gives the actual hypervisor binary an
+# unhelpfully-varying name, like 'xen-4.14.1-pre.gz'. The symlinks to
+# this binary have more stable names, which we can use to our advantage.
 #
-# For our part, we have been in the habit of putting the flavour in
-# the name and want to continue to do so for continuity.  (This was
-# more useful when the -i386 flavour existed and was coinstallable
-# with the -amd64 flavour.)
-
+# First of all, we figure out the version string that is used in the
+# upstream build result. So, for xen-4.14.1-pre.gz that would be
+# 4.14.1-pre
 verstring="$(readlink debian/tmp/boot/xen.gz ||
             readlink debian/tmp/boot/xen)"
 verstring="${verstring##*xen-}"
 verstring="${verstring%.gz}"
 
+# Next we substitute this upstream version string with our own format.
+# For our part, we have been in the habit of putting the flavour in the
+# name and want to continue to do so for continuity.  (This was more
+# useful when the -i386 flavour existed and was coinstallable with the
+# -amd64 flavour.)
+#
+# So, e.g. debian/tmp/boot/xen-4.14.1-pre.gz will end up in our package
+# as debian/xen-hypervisor-4.14-amd64/boot/xen-4.14-amd64.gz
 find "$t/boot" -type f -print | while read f; do
 	basename="${f#$t/boot/}"
 	head="${basename%$verstring*}"