From: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Date: Wed, 5 Oct 2022 13:43:56 +0000 (+0200)
Subject: fix more issues reported by sonarcloud
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~11^2~192^2~2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=5e81ab821e932992ffc64cc8337cb79047250adf;p=nextcloud-desktop.git

fix more issues reported by sonarcloud

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
---

diff --git a/src/libsync/clientsideencryption.cpp b/src/libsync/clientsideencryption.cpp
index 9bd5919ea..e7b579d62 100644
--- a/src/libsync/clientsideencryption.cpp
+++ b/src/libsync/clientsideencryption.cpp
@@ -1193,7 +1193,7 @@ void ClientSideEncryption::sendSignRequestCSR(const AccountPtr &account, PKey ke
     auto job = new SignPublicKeyApiJob(account, e2eeBaseUrl() + "public-key", this);
     job->setCsr(csrContent);
 
-    connect(job, &SignPublicKeyApiJob::jsonReceived, [this, account, keyPair = std::move(keyPair)](const QJsonDocument& json, int retCode) {
+    connect(job, &SignPublicKeyApiJob::jsonReceived, [this, account, keyPair = std::move(keyPair)](const QJsonDocument& json, const int retCode) {
         if (retCode == 200) {
             const auto cert = json.object().value("ocs").toObject().value("data").toObject().value("public-key").toString();
             _certificate = QSslCertificate(cert.toLocal8Bit(), QSsl::Pem);
@@ -1205,7 +1205,7 @@ void ClientSideEncryption::sendSignRequestCSR(const AccountPtr &account, PKey ke
             const auto x509Certificate = X509Certificate::readCertificate(certificateBio);
 
             if (const auto certificateCheckResult = X509_check_private_key(x509Certificate, keyPair) ; !certificateCheckResult) {
-                auto lastError = 1;
+                auto lastError = 1ul;
                 while ((lastError= ERR_get_error())) {
                     qCInfo(lcCse()) << ERR_lib_error_string(lastError);
                 }