From: bors Date: Wed, 14 Dec 2016 01:19:37 +0000 (+0000) Subject: Auto merge of #3386 - matklad:warn-replace, r=alexcrichton X-Git-Tag: archive/raspbian/0.35.0-2+rpi1~3^2^2^2^2^2^2^2~22^2~11^2~86 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=5e4a4e0f39f0dfac797f0273023dc51e2548b12d;p=cargo.git Auto merge of #3386 - matklad:warn-replace, r=alexcrichton Warn if replace is not actually used closes #3324 I've added warnings to `resolve_dependencies` inside `cargo_compile.rs`. Adding them to `resolve_with_previous` does not work because that method is called several times. Perhaps the best idea is to refactor resolve facade, such that we have only `ops::resolve` and not `ops::resolve_ws`, `ops::resolve_with_previous` and `ops::resolve_dependencies`. IIRC, there were some bugs because of logic mismatch between `compile` and `metadata` commands. --- 5e4a4e0f39f0dfac797f0273023dc51e2548b12d