From: Stefano Stabellini Date: Tue, 20 Jul 2010 16:22:14 +0000 (+0100) Subject: implement xl vncviewer X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~11759^2~2 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=5d7dda7847a49d110636df99f84813ff5b5ea75e;p=xen.git implement xl vncviewer Implement xl vncviewer. The only difference from xm vncviewer is that we obey the VNCVIEWER environment variable. Signed-off-by: Gianni Tedesco Signed-off-by: Stefano Stabellini --- diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index b8ed890a39..6c5b06559f 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -843,6 +843,69 @@ int libxl_primary_console_exec(struct libxl_ctx *ctx, uint32_t domid_vm) return libxl_console_exec(ctx, domid_vm, 0); } +int libxl_vncviewer_exec(struct libxl_ctx *ctx, uint32_t domid, int autopass) +{ + const char *vnc_port, *vfb_back; + const char *vnc_listen = NULL, *vnc_pass = NULL; + int port = 0, autopass_fd = -1; + char *vnc_bin, *args[] = { + "vncviewer", + NULL, /* hostname:display */ + NULL, /* -autopass */ + NULL, + }; + + vnc_port = libxl_xs_read(ctx, XBT_NULL, + libxl_sprintf(ctx, + "/local/domain/%d/console/vnc-port", domid)); + if ( vnc_port ) + port = atoi(vnc_port) - 5900; + + vfb_back = libxl_xs_read(ctx, XBT_NULL, + libxl_sprintf(ctx, + "/local/domain/%d/device/vfb/0/backend", domid)); + if ( vfb_back ) { + vnc_listen = libxl_xs_read(ctx, XBT_NULL, + libxl_sprintf(ctx, + "/local/domain/%d/console/vnc-listen", domid)); + if ( autopass ) + vnc_pass = libxl_xs_read(ctx, XBT_NULL, + libxl_sprintf(ctx, + "/local/domain/%d/console/vnc-pass", domid)); + } + + if ( NULL == vnc_listen ) + vnc_listen = "localhost"; + + if ( (vnc_bin = getenv("VNCVIEWER")) ) + args[0] = vnc_bin; + + args[1] = libxl_sprintf(ctx, "%s:%d", vnc_listen, port); + + if ( vnc_pass ) { + char tmpname[] = "/tmp/vncautopass.XXXXXX"; + autopass_fd = mkstemp(tmpname); + if ( autopass_fd < 0 ) + goto skip_autopass; + + if ( unlink(tmpname) ) + /* should never happen */ + XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "unlink %s failed", tmpname); + + if ( libxl_write_exactly(ctx, autopass_fd, vnc_pass, strlen(vnc_pass), + tmpname, "vnc password") ) { + do { close(autopass_fd); } while(errno == EINTR); + goto skip_autopass; + } + + args[2] = "-autopass"; + } + +skip_autopass: + libxl_exec(autopass_fd, -1, -1, args[0], args); + return 0; +} + static char ** libxl_build_device_model_args(struct libxl_ctx *ctx, libxl_device_model_info *info, libxl_device_nic *vifs, diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index 1c7484747f..057840ffc6 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -400,6 +400,7 @@ int libxl_domain_core_dump(struct libxl_ctx *ctx, uint32_t domid, const char *fi int libxl_domain_setmaxmem(struct libxl_ctx *ctx, uint32_t domid, uint32_t target_memkb); int libxl_set_memory_target(struct libxl_ctx *ctx, uint32_t domid, uint32_t target_memkb, int enforce); +int libxl_vncviewer_exec(struct libxl_ctx *ctx, uint32_t domid, int autopass); int libxl_console_exec(struct libxl_ctx *ctx, uint32_t domid, int cons_num); /* libxl_primary_console_exec finds the domid and console number * corresponding to the primary console of the given vm, then calls diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h index 79a4204621..f0bff2af9d 100644 --- a/tools/libxl/xl.h +++ b/tools/libxl/xl.h @@ -30,6 +30,7 @@ int main_info(int argc, char **argv); int main_cd_eject(int argc, char **argv); int main_cd_insert(int argc, char **argv); int main_console(int argc, char **argv); +int main_vncviewer(int argc, char **argv); int main_pcilist(int argc, char **argv); int main_pcidetach(int argc, char **argv); int main_pciattach(int argc, char **argv); diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 3379252a37..8e62c0baaf 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -1654,6 +1654,52 @@ int main_console(int argc, char **argv) return 1; } +static int vncviewer(const char *domain_spec, int autopass) +{ + find_domain(domain_spec); + libxl_vncviewer_exec(&ctx, domid, autopass); + fprintf(stderr, "Unable to execute vncviewer\n"); + return 1; +} + +int main_vncviewer(int argc, char **argv) +{ + static const struct option long_options[] = { + {"autopass", 0, 0, 'a'}, + {"vncviewer-autopass", 0, 0, 'a'}, + {"help", 0, 0, 'h'}, + {0, 0, 0, 0} + }; + int opt, autopass = 0; + + while (1) { + opt = getopt_long(argc, argv, "ah", long_options, NULL); + if (opt == -1) + break; + + switch (opt) { + case 'a': + autopass = 1; + break; + case 'h': + help("vncviewer"); + exit(0); + default: + fprintf(stderr, "option not supported\n"); + break; + } + } + + if (argc - optind != 1) { + help("vncviewer"); + exit(2); + } + + if (vncviewer(argv[optind], autopass)) + exit(1); + exit(0); +} + void pcilist(char *dom) { libxl_device_pci *pcidevs; diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c index 1621cbb435..3d9c5f1566 100644 --- a/tools/libxl/xl_cmdtable.c +++ b/tools/libxl/xl_cmdtable.c @@ -83,6 +83,14 @@ struct cmd_spec cmd_table[] = { "Attach to domain's console", "", }, + { "vncviewer", + &main_vncviewer, + "Attach to domain's VNC server.", + "[options] \n" + "--autopass Pass VNC password to viewer via stdin and\n" + " -autopass\n" + "--vncviewer-autopass (consistency alias for --autopass)" + }, { "save", &main_save, "Save a domain state to restore later",