From: Markus Goetz <markus@woboq.com>
Date: Thu, 22 Jun 2017 13:42:56 +0000 (+0200)
Subject: Jenkinsfile: Some comments
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~710^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=59bbbd5e66e41415e79a31079d130bbc5ae296b3;p=nextcloud-desktop.git

Jenkinsfile: Some comments
---

diff --git a/Jenkinsfile b/Jenkinsfile
index fc0acb898..f8d6f9dd7 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -1,5 +1,12 @@
 #!groovy
 
+//
+// We now run the tests in Debug mode so that ASSERTs are triggered.
+// Ideally we should run the tests in both Debug and Release so we catch
+// all possible error combinations.
+// See also the top comment in syncenginetestutils.h
+//
+
 node('CLIENT') {
     stage 'Checkout'
         checkout scm
@@ -37,6 +44,8 @@ node('CLIENT') {
 		ctest .
 		'''
 	}
+
+   // Stage 'macOS' TODO
 }
 
 
diff --git a/test/syncenginetestutils.h b/test/syncenginetestutils.h
index ee15d8e33..997e5054e 100644
--- a/test/syncenginetestutils.h
+++ b/test/syncenginetestutils.h
@@ -17,6 +17,12 @@
 #include <QMap>
 #include <QtTest>
 
+/*
+ * TODO: In theory we should use QVERIFY instead of Q_ASSERT for testing, but this
+ * only works when directly called from a QTest :-(
+ */
+
+
 static const QUrl sRootUrl("owncloud://somehost/owncloud/remote.php/webdav/");
 static const QUrl sRootUrl2("owncloud://somehost/owncloud/remote.php/dav/files/admin/");
 static const QUrl sUploadUrl("owncloud://somehost/owncloud/remote.php/dav/uploads/admin/");