From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 22 Dec 2025 20:25:04 +0000 (+0200)
Subject: [PATCH] managesieve-login: Fix crash when command didn't finish on the first call
X-Git-Tag: archive/raspbian/1%2.4.1+dfsg1-6+rpi1+deb13u4^2~23
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=5768f81fc2b0ddbe6bba4536b11a3f3032388bf6;p=dovecot.git

[PATCH] managesieve-login: Fix crash when command didn't finish on the first call


Gbp-Pq: Name CVE-2025-59032.patch
---

diff --git a/pigeonhole/src/managesieve-login/client.c b/pigeonhole/src/managesieve-login/client.c
index cc0aa46..c0711cd 100644
--- a/pigeonhole/src/managesieve-login/client.c
+++ b/pigeonhole/src/managesieve-login/client.c
@@ -336,10 +336,12 @@ static bool managesieve_client_input_next_cmd(struct client *client)
 			if (args[0].type != MANAGESIEVE_ARG_EOL)
 				ret = -1;
 		}
-	}
-	if (ret > 0) {
+		if (ret > 0)
+			ret = msieve_client->cmd->func(msieve_client, args);
+	} else {
+		/* Continue unfinished command */
 		i_assert(msieve_client->cmd != NULL);
-		ret = msieve_client->cmd->func(msieve_client, args);
+		ret = msieve_client->cmd->func(msieve_client, NULL);
 	}
 
 	if (ret != 0)