From: Christian Kamm <mail@ckamm.de>
Date: Tue, 30 Jul 2019 11:40:52 +0000 (+0200)
Subject: SyncEngine: Don't duplicate fatal errors
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~21^2~468^2~212
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=5761f4cd8aeb31c2b58e1e00d6ff72caa56dd8c7;p=nextcloud-desktop.git

SyncEngine: Don't duplicate fatal errors

Previously fatal error texts were duplicated: Once they entered the
SyncResult via the SyncFileItem and once via syncError().

syncError is intended for folder-wide sync issues that are not pinned
to particular files. Thus that duplicated path is removed.

For #5088
---

diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp
index b5eef406f..4e75da8e0 100644
--- a/src/libsync/syncengine.cpp
+++ b/src/libsync/syncengine.cpp
@@ -827,10 +827,6 @@ void SyncEngine::slotItemCompleted(const SyncFileItemPtr &item)
 {
     _progressInfo->setProgressComplete(*item);
 
-    if (item->_status == SyncFileItem::FatalError) {
-        syncError(item->_errorString);
-    }
-
     emit transmissionProgress(*_progressInfo);
     emit itemCompleted(item);
 }