From: Jan Beulich <jbeulich@suse.com>
Date: Tue, 26 Nov 2019 13:17:45 +0000 (+0100)
Subject: EFI: fix "efi=attr=" handling
X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~63^2~1146
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=5530782cfe70ed22fe44358f6a10c38916443b42;p=xen.git

EFI: fix "efi=attr=" handling

Commit 633a40947321 ("docs: Improve documentation and parsing for efi=")
failed to honor the strcmp()-like return value convention of
cmdline_strcmp().

Reported-by: Roman Shaposhnik <roman@zededa.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wl@xen.org>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
---

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index a8b6f39721..3f1c330afe 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1430,9 +1430,9 @@ static int __init parse_efi_param(const char *s)
         }
         else if ( (ss - s) > 5 && !memcmp(s, "attr=", 5) )
         {
-            if ( cmdline_strcmp(s + 5, "uc") )
+            if ( !cmdline_strcmp(s + 5, "uc") )
                 efi_map_uc = true;
-            else if ( cmdline_strcmp(s + 5, "no") )
+            else if ( !cmdline_strcmp(s + 5, "no") )
                 efi_map_uc = false;
             else
                 rc = -EINVAL;